Skip to content

Conversation

@Flamefire
Copy link
Collaborator

Exclude uncovered lines in test_encoding which are only run on macos-15 with faulty iconv implementation

Show more information for the coverage run on Windows GHA to find why ICU isn't used.

It needs forward slashes even on Windows
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.79%. Comparing base (57cda42) to head (b38a271).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
- Coverage    95.93%   95.79%   -0.14%     
===========================================
  Files          119      119              
  Lines        10370    10346      -24     
===========================================
- Hits          9948     9911      -37     
- Misses         422      435      +13     
Files with missing lines Coverage Δ
test/show_config.cpp 100.00% <100.00%> (+1.78%) ⬆️
test/test_encoding.cpp 100.00% <ø> (+0.68%) ⬆️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cda42...b38a271. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Flamefire Flamefire closed this Nov 2, 2025
@Flamefire Flamefire reopened this Nov 2, 2025
@Flamefire Flamefire merged commit bf8ca46 into develop Nov 2, 2025
102 of 103 checks passed
@Flamefire Flamefire deleted the coverage branch November 2, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants